ensure drops is not null #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pilzinsel64
force-pushed
the
fix/crash-on-efr
branch
2 times, most recently
from
d76af20 to
a3d05a0
Compare
-> got removed via commit d361e08
Pilzinsel64
force-pushed
the
fix/crash-on-efr
branch
from
a3d05a0 to
c37b3c2
Compare
serenibyss
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-> got removed falsely via commit d361e08 from #478
This change was important to fix a server crash due NullPointerException from EFR that assumes this isn't null. Reason is that the super method thinks it can't handle it and just return null.
Wasn't able to test again until now after glows changes, and well, it was merged already. That's why this PR.