Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix extra utilities ender quarry freeze/soft-lock randomly #480

Merged
merged 2 commits into from
Jan 25, 2025

Conversation

Pilzinsel64
Copy link
Contributor

@Pilzinsel64 Pilzinsel64 commented Jan 23, 2025

This fixes an issue where the Ender Quarry get stuck at a mostly random location and wont continue with anything (soft-lock). The only thing that works at this point is breaking the quarry. placing it and starting again from zero.

The source are a few blocks from mods that either drop nothing (having a few blocks in mind, but random mods) or mods that converts their blocks while harvesting (hello Underground Biomes Construct).

To prevent this issue we need to return true also in the following (so all available) scenario at the method harvestBlock:

  • The harvested block has no drops
  • The harvested block has unexpected drops
  • The harvested block has been harvested by another Entity

New possible effects:

  • If the block can't be harvested for some good reason, the drops (if available) get stored in the inventory and the energy will be used anyway. Don't matter if the block was really replaced with dirt or not.
  • The energy get used don't matter if the item has drops or not. It's fine in my optinion as the quarry should need energy even for the try.

Not tested in the full pack, might need to check someone else. I only tested in my own full pack.

@Pilzinsel64 Pilzinsel64 requested a review from a team January 23, 2025 11:37
@Pilzinsel64 Pilzinsel64 changed the title fix extra utilities ender quarry freeze randomly fix extra utilities ender quarry freeze/soft-lock randomly Jan 23, 2025
@serenibyss serenibyss merged commit e2c5507 into master Jan 25, 2025
2 checks passed
@serenibyss serenibyss deleted the fix/extrautilities/enderquarryfreeze branch January 25, 2025 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants