Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my world lava constantly loads chunks, causing quite a big performance hit. It's not so big that it's causing tps lag, but at the same time it's taking up 10-20% of my tick time, so it's low hanging fruit.
I've redirected several
World.getBlock
+ analogues to check if the chunk is loaded first, and if it's not, bail. This change is fairly low risk, since this logic is only used to set flammable things around lava on fire.Before:
https://spark.lucko.me/kUlsa23drS
BlockLiquidStatic only calls the update method, which only contains the fire logic for lava.

After:
https://spark.lucko.me/xjzUlFbAka