Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed so amount field is saved when going in and out of window #16

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

Bmandk
Copy link

@Bmandk Bmandk commented Aug 7, 2024

I introduced a small bug where the amount of items for the current item is not being saved. This is fixed here by saving it to records.

@Caedis
Copy link
Member

Caedis commented Aug 7, 2024

Can you figure a better way to write getCurrentAmount? You also left that unchecked

@Dream-Master Dream-Master requested a review from a team August 7, 2024 17:00
@Bmandk
Copy link
Author

Bmandk commented Aug 7, 2024

Pushed a change, so it now uses input validation and you can't even type non-numeric characters. Code seems better, but let me know if you think there's a better way.

@Caedis
Copy link
Member

Caedis commented Aug 7, 2024

[^0-9] can technically be replaced with \D (not a digit)

@Caedis Caedis merged commit b708eb3 into GTNewHorizons:master Aug 7, 2024
1 check passed
@Bmandk Bmandk deleted the fix-amount-saving branch August 7, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants