Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix CME when opening recipes immediately after load #403

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

eigenraven
Copy link
Member

Cancel recipe/usage open events while the config is still loading to avoid ConcurrentModificationExceptions on the handlers list.

@eigenraven eigenraven requested review from a team July 16, 2023 07:50
@eigenraven eigenraven self-assigned this Jul 16, 2023
@eigenraven eigenraven merged commit d613d06 into master Jul 16, 2023
1 check passed
@eigenraven eigenraven deleted the cme-fix-attempt branch July 16, 2023 08:00
Dream-Master pushed a commit that referenced this pull request Jul 23, 2023
* Unconditionally override Minecraft.currentScreen when drawing tooltips

* Fix bad item lighting in recipe tooltips

* Update buildscript

* Fix NEI ignoring handler switching on click

Handlers might call Minecraft#displayGuiScreen and overwrite Minecraft.currentScreen, but the height hack would unconditionally undo this again.

* spotlessApply (#404)

Co-authored-by: GitHub GTNH Actions <>

* Attempt to fix CME when opening recipes immediately after load (#403)

* Rename the internal private class HeightHack->CompatibilityHacks to better reflect the new usage.

* Move trueGui assignment down.

* Fix overlay button y offsets

* Fix wrong recipe tooltip background rendering

* Apply spotless

---------

Co-authored-by: Wilhelm Schuster <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants