Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chat message to chunk overlay key press #450

Merged
merged 2 commits into from
Jan 8, 2024

Conversation

Caedis
Copy link
Member

@Caedis Caedis commented Jan 8, 2024

Preview:
image

@Caedis Caedis requested a review from a team January 8, 2024 18:33
@bombcar
Copy link
Member

bombcar commented Jan 8, 2024

Is this that F7 thing or whatever it is that shows you where ore veins are?

If so, isn't "chunk corners" and "chunks" a bit misleading (as the first is "ore chunks" and second is "minecraft chunks")

@Caedis
Copy link
Member Author

Caedis commented Jan 8, 2024

F7 is light overlay. F9 is the chunk overlay

The 3rd one is only shown when GT5 is loaded
chunkOverlay = (chunkOverlay + 1) % (NEIModContainer.isGT5Loaded() ? 4 : 3);

thus it can never be the first one

The preview is from the NEI dev env without GT loaded

@Caedis Caedis merged commit f35a92a into master Jan 8, 2024
1 check passed
@Caedis Caedis deleted the feature/chunkOverlayMessage branch January 8, 2024 19:36
Dream-Master pushed a commit that referenced this pull request Jan 8, 2024
* Add chat message to chunk overlay key

* spotless
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants