Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable cycle through NEI Modes if lockmode is ON #539

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Disable cycle through NEI Modes if lockmode is ON #539

merged 1 commit into from
Oct 2, 2024

Conversation

AtHisF1nest
Copy link

It was possible to cycle through modes in NEI even though lockmode was set in the config (with CTRL+Click).

  • I have disabled that if the lockmode is set based on a method in NEIClientConfig. This method also validates the property.
  • Removed the tooltip with cycling if the lockmode is set (because there is no point in showing that in my opinion)

Tested on SP and on Private Server.

Fixed issue: #17509

@Dream-Master Dream-Master requested a review from a team September 30, 2024 13:28
@Dream-Master Dream-Master merged commit a41299d into GTNewHorizons:master Oct 2, 2024
1 check passed
@AtHisF1nest AtHisF1nest deleted the fix-lockmode branch October 2, 2024 18:47
RaidhoSketch pushed a commit to RaidhoSketch/NotEnoughItems-Fork that referenced this pull request Oct 6, 2024
@AtHisF1nest @RaidhoSketch
fix issue #17509 (GTNewHorizons#539)
517775b 
Co-authored-by: Marcin Siekierski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OneEyeMaker OneEyeMaker OneEyeMaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AtHisF1nest @OneEyeMaker @Dream-Master