Update Lever Block once again and fix IC2 integration #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also small fix in lever block code
refactor lever code to be easier to read
deobufscated some parameters
Keridos
changed the title
OneEyeMaker
requested changes
Aug 29, 2024
src/main/java/openmodularturrets/tileentity/turretbase/TurretBase.java
Outdated
Show resolved
Hide resolved
rename parameters Co-authored-by: Alexander Anishin <[email protected]>
simplify turretdirection Co-authored-by: Alexander Anishin <[email protected]>
…ase.java simplify potentiaUpgradeConversion Co-authored-by: Alexander Anishin <[email protected]>
…/TurretBase.java " This reverts commit 81008ba.
OneEyeMaker
requested changes
Sep 10, 2024
src/main/java/openmodularturrets/blocks/turretbases/BlockAbstractTurretBase.java
Outdated
Show resolved
Hide resolved
src/main/java/openmodularturrets/tileentity/turretbase/TurretBase.java
Outdated
Show resolved
Hide resolved
…actTurretBase.java Co-authored-by: Alexander Anishin <[email protected]>
refactor a bit
OneEyeMaker
approved these changes
Sep 10, 2024
|
Weird my IDE did not catch that error. May need to enable intellij to try to compile the whole project before commiting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should probably squash the commits since I had to merge the latest changes again.