-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kill Count Tracking and GUI Updates for TurretBase #9
Conversation
Added killcount
Add onKill function
-Added call OnKill for every projectile when Entity is killed
I have created a pull request to address this issue: GTNewHorizons/GT-New-Horizons-Modpack#18740 |
src/main/java/openmodularturrets/tileentity/turretbase/TurretBase.java
Outdated
Show resolved
Hide resolved
src/main/java/openmodularturrets/entity/projectiles/BlazingClayProjectile.java
Outdated
Show resolved
Hide resolved
src/main/java/openmodularturrets/entity/projectiles/DisposableTurretProjectile.java
Outdated
Show resolved
Hide resolved
src/main/java/openmodularturrets/entity/projectiles/FerroSlugProjectile.java
Outdated
Show resolved
Hide resolved
src/main/java/openmodularturrets/entity/projectiles/GrenadeProjectile.java
Outdated
Show resolved
Hide resolved
src/main/java/openmodularturrets/entity/projectiles/LaserProjectile.java
Outdated
Show resolved
Hide resolved
…yProjectile.java Co-authored-by: Maya <[email protected]>
@mak8427 Thanks for addressing the reviews, this PR looks good now. Could you run |
It should hopefully work now. I helped mak find the issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR introduces several updates and new features to the OpenModularTurrets project, specifically focusing on tracking the kill count for turrets and displaying this information in the GUI. The following changes have been made:
TurretBase.java:
killCount
field to track the number of kills made by the turret.onKill
method to increment the kill count when an entity is killed.killCount
.writeToNBT
andreadFromNBT
methods to save and load the kill count.GUI Updates:
Projectile Updates:
Closes GTNewHorizons/GT-New-Horizons-Modpack#18740