Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Accessor: Check for Correct Dimension #14

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

Vlamonster
Copy link

Fixes potential exploits.

@Dream-Master Dream-Master requested a review from a team September 28, 2024 21:34
@Dream-Master
Copy link
Member

@Vlamonster was there a reported issue ? If yes can you link it ?

@Vlamonster
Copy link
Author

@Vlamonster was there a reported issue ? If yes can you link it ?

No, this fix is due to an exploit I found a couple hours ago that is quite severe.

@Dream-Master
Copy link
Member

Ah ok

@Lyfts
Copy link
Member

Lyfts commented Sep 28, 2024

activateBlock already gets and activates the block in the world that the player is currently in, so what makes this extra check needed?

Block block = proxyPlayer.worldObj.getBlock(x, y, z);

block.onBlockActivated(proxyPlayer.worldObj, x, y, z, proxyPlayer, side, fx, fy, fz);

@Vlamonster
Copy link
Author

In a test world I was able to bind a Remote Accessor to a block with coordinate x,y,z and then interact with a block at coordinate x,y,z in another dimension. This operation bypasses town claims on public servers.

@Dream-Master Dream-Master merged commit 4390529 into GTNewHorizons:master Sep 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants