Cleanup #18
Merged
Cleanup #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyfts
reviewed
Feb 19, 2024
|
|
||
| // TODO: http://minecraft.gamepedia.com/Data_values_%28Classic%29 | ||
| // TODO: https://web.archive.org/web/20170708003352/http://minecraft.gamepedia.com/Data_values_(Classic) | ||
| public class SchematicClassic extends SchematicFormat { |
There was a problem hiding this comment.
In the spirit of cleanup can't this entire class be removed?
It doesn't seem to do anything.
There was a problem hiding this comment.
You're probably right, I am intending to provide public support to this fork though so we'll have to be fully sure first. I'll look if the versions for later releases of the game have anything here, if not we can indeed remove
There was a problem hiding this comment.
it seems to have never been implemented so I'll remove the class once I'm done with work
Lyfts
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.