Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basic Pregenerator #121

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Cardinalstars
Copy link

More work will eventually be needed to make it better, but this works to generate a circle for now.

Will want to make a GUI to select the areas specifically and add a square generation area.

@Dream-Master Dream-Master requested review from Lyfts and a team October 3, 2024 08:18

public PregeneratorFileManager(MinecraftServer server, double xLoc, double zLoc, int radius, int dimensionID)
throws IOException {
Path temporaryFileSaveFolder = Paths.get("saves").resolve(getWorldFolderPath(server).resolve(COMMAND_FOLDER));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if the temp files are made in some subfolder of the serverutilities folder, if they're in the world folder and backups are running then all of the temp files will be zipped up.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I'll be sure to move those over. Just had it there for the moment.

src/main/resources/assets/serverutilities/lang/en_US.lang Outdated Show resolved Hide resolved
@Lyfts
Copy link
Member

Lyfts commented Oct 3, 2024

This is using impressively little ram to the point that there is definitely some wiggle room if you ever wanted it to go faster.

@chochem chochem added the ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version label Oct 3, 2024
@Cardinalstars
Copy link
Author

Cardinalstars commented Oct 6, 2024

This is using impressively little ram to the point that there is definitely some wiggle room if you ever wanted it to go faster.

Weird things start happening when I up to 2 chunks per tick. I can do something like 2 chunks every other tick. Most testing will be required before I'm happy upping the speed. I can maybe add a config for how fast? It really might just depend on your system speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ongoing freeze - do not merge Not just a bug fix and thus affected by a current freeze for a upcoming version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants