Potential fix for disappearing sidebar buttons #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lyfts
force-pushed
the
fix-buttons-disappear
branch
from
291cec2 to
5c20b9a
Compare
|
I can confirm that this fixed the issue for one player. |
OneEyeMaker
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes the problem mentioned in #28.
I haven't been able to replicate the issue at all and thus I can't really say for sure if this fixes it. I do however have a pretty good idea of what the problem is and can at the very least say that this doesn't break anything.
SERVER_MODS_0.clear()has been moved inside the same check that the put is in, since there's really no reason to clear the map if an empty map is received...There might also be some cases where another NetworkCheckHandler list gets sent out after joining a server thus overwriting the map. So instead of checking a map that can be wiped/overwritten if forge decides to be forge, we take a copy of it when joining the server and check that one instead.
Generic injections has also been enabled. It's not related to the issue in any way, the unchecked warnings were simply just annoying.