Hotkey Updates #34
Merged
Hotkey Updates #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add a few comments
wlhlm
added
the
ongoing freeze - don't merge
Dream-Master
removed
the
ongoing freeze - don't merge
serenibyss
reviewed
Dec 27, 2024
There was a problem hiding this comment.
@Akeianova sorry for taking so long to review! I left a couple comments and questions
Removed incorrect non-support comment
fix jump and speed change function logic
|
I also apologize, but I do not have access to my dev environment at the moment so if this is incorrect I will have to fix it properly at a later date |
|
@Akeianova Yeah, the change to Config I meant to change the text like: - The rate that boot jump and speed modifiers change when the Jump/Speed Modulation key is pressed. 'Modified values will not receive support'
+ The rate that boot jump and speed modifiers change when the Jump/Speed Modulation key is pressed.rather than remove the whole line. No rush, take your time |
|
fixed the config changes, my bad |
serenibyss
approved these changes
Dec 31, 2024
serenibyss
removed
the
🚧 Testing on Zeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new modifier to increase granularity in jump and speed modularity. Also ensures that increments are locked to multiples of 5 to avoid value drift.