Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactor, add in support for the nanochestplate for thaumic boots #35

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

Keridos
Copy link
Contributor

@Keridos Keridos commented Jan 4, 2025

Rename runBonus to speedBonus as that is more accurate since it affects creative flight speed.
Add in a check for the advanced Nanochestplate from GraviSuite so that it is supported, too.
It checks if the chest armor of the player is that specific part and if its in fly and hover mode.
Reason for that:
EMT Boots do work with the advanced Nanochestplate. Since f.ex. the Voidwalker boots are a direct upgrade from the EMT Boots it feels wrong for them to lose that ability in the process. Now Thaumic Boots behave the same as the EMT Boots in that regard.
This also fixes inertia cancelling with these boots.

Fixes GTNewHorizons/GT-New-Horizons-Modpack#17831

Copy link
Member

@chochem chochem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EMT Boots do work with the advanced Nanochestplate

you might have been mislead. that is a bug. see GTNewHorizons/GT-New-Horizons-Modpack#12864, caused by GTNewHorizons/Electro-Magic-Tools#53, wasnt the case before.

@Keridos
Copy link
Contributor Author

Keridos commented Jan 4, 2025

EMT Boots do work with the advanced Nanochestplate

you might have been mislead. that is a bug. see GTNewHorizons/GT-New-Horizons-Modpack#12864, caused by GTNewHorizons/Electro-Magic-Tools#53, wasnt the case before.

Well, is it really a bug if that was not fixed since almost 2 years?
I feel like the nanochestplate and boots of traveler are a pretty balanced approach to flying. Getting creative flight is way easier with magic then going the tech route.
While I recognize that the EMT boots giving flying bonus might have been a bug, I think that that bug actually improves balancing.
Speaking of balancing, I'd rather tune down the speed bonus of some of the Thaumic Boots. Especially Quantum Voidwalker is way to fast imo. It more than doubles the bonus of the nano voidwalker boots.
Or seperate running and flying bonus so that they can be tweaked individually.

@Dream-Master Dream-Master requested a review from a team January 4, 2025 15:08
@Alastors
Copy link

Alastors commented Jan 6, 2025

Rename runBonus to speedBonus as that is more accurate since it affects creative flight speed.

Just going to say it, randomly changing variable names for subjective reasons is not a good practice, though for context, the runBonus thing is just keeping in tune with the original thaum code.

@serenibyss serenibyss merged commit b608944 into GTNewHorizons:master Jan 19, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase flying speed of the fused voidwalker boots (NanoSuit Voidwalker Boots, Quantum Voidwalker Boots)
4 participants