Allow hiding of Traveller's Gear accessories (gloves and belt) through config option and Translucency enchant #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…splaying on player model
…aveler's accessories (must enchant from book for now)
OneEyeMaker
requested changes
Oct 9, 2024
OneEyeMaker
approved these changes
Oct 10, 2024
|
Is it possible to reopen a PR? @OneEyeMaker's help in GTNewHorizons/AdventureBackpack2#23 helped me figure out how to make the Traveller Glove and Belt infusable, so I'd like to add that in as well if possible. Or should I just make a new PR again? |
|
@Kortako Feel free to make another PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Traveller's Belt and Glove can now be hidden from rendering on the body through a config option, or they can be enchanted with Translucency I or II from Witching Gadgets and that will work as expected too. Unfortunately I couldn't figure out how to get the infusion itself to detect the recipe properly with either the glove or the belt, so in order to apply the enchantment you will need to get it onto a book first and apply it with an anvil.