Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ItemMagnet.java #33

Merged
merged 1 commit into from
Mar 24, 2024
Merged

Conversation

nikita23830
Copy link

@nikita23830 nikita23830 commented Mar 16, 2024

Ordnungsgemäße Trennung in Server und Client. Sonst geht die Logik verloren, wenn "!world.isRemote" ein Paket an den Server sendet... Es bringt den Server zum Absturz.


Proper separation for server and client. Otherwise the logic is lost when "!world.isRemote" sends a packet to the server... it crashes the server.

Ordnungsgemäße Trennung in Server und Client. Sonst geht die Logik verloren, wenn "!world.isRemote" ein Paket an den Server sendet...
Es bringt den Server zum Absturz.
@boubou19
Copy link
Member

Can you explain in english what does this PR pls?

@nikita23830
Copy link
Author

In the original code, it tries to send a packet to the server (sendToServer) even though the code is processed on the server side (!world.isRemote), which causes a critical error on the server

@nikita23830
Copy link
Author

[17:13:25 WARN]: More than one exception was raised. Will report only the first one and log others.
java.lang.RuntimeException: Missing
        at cpw.mods.fml.server.FMLServerHandler.getClientToServerNetworkManager(FMLServerHandler.java:238) ~[FMLServerHandler.class:1.1.8]
        at cpw.mods.fml.common.FMLCommonHandler.getClientToServerNetworkManager(FMLCommonHandler.java:571) ~[FMLCommonHandler.class:1.1.8]
        at cpw.mods.fml.common.network.FMLOutboundHandler$OutboundTarget$8.selectNetworks(FMLOutboundHandler.java:292) ~[FMLOutboundHandler$OutboundTarget$8.class:1.1.8]
        at cpw.mods.fml.common.network.FMLOutboundHandler.write(FMLOutboundHandler.java:340) ~[FMLOutboundHandler.class:1.1.8]
        at io.netty.channel.DefaultChannelHandlerContext.invokeWrite(DefaultChannelHandlerContext.java:644) ~[DefaultChannelHandlerContext.class:?]
        at io.netty.channel.DefaultChannelHandlerContext.write(DefaultChannelHandlerContext.java:698) ~[DefaultChannelHandlerContext.class:?]
        at io.netty.channel.DefaultChannelHandlerContext.writeAndFlush(DefaultChannelHandlerContext.java:688) ~[DefaultChannelHandlerContext.class:?]
        at io.netty.channel.DefaultChannelHandlerContext.writeAndFlush(DefaultChannelHandlerContext.java:717) ~[DefaultChannelHandlerContext.class:?]
        at io.netty.channel.DefaultChannelPipeline.writeAndFlush(DefaultChannelPipeline.java:893) ~[DefaultChannelPipeline.class:?]
        at io.netty.channel.AbstractChannel.writeAndFlush(AbstractChannel.java:239) ~[AbstractChannel.class:?]
        at cpw.mods.fml.common.network.FMLEmbeddedChannel.writeAndFlush(FMLEmbeddedChannel.java:100) ~[FMLEmbeddedChannel.class:1.1.8]
        at cpw.mods.fml.common.network.FMLEventChannel.sendToServer(FMLEventChannel.java:173) ~[FMLEventChannel.class:1.1.8]
        at net.p455w0rd.wirelesscraftingterminal.core.sync.network.NetworkHandler.sendToServer(NetworkHandler.java:85) ~[NetworkHandler.class:?]
        at net.p455w0rd.wirelesscraftingterminal.items.ItemMagnet.func_77659_a(ItemMagnet.java:200) ~[ItemMagnet.class:?]
        at net.minecraft.item.ItemStack.func_77957_a(ItemStack.java:167) ~[add.class:?]
        at net.minecraft.server.management.ItemInWorldManager.func_73085_a(ItemInWorldManager.java:379) ~[mx.class:?]
        at net.minecraft.network.NetHandlerPlayServer.func_147346_a(NetHandlerPlayServer.java:807) ~[nh.class:?]
        at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(C08PacketPlayerBlockPlacement.java:64) ~[jo.class:?]
        at net.minecraft.network.play.client.C08PacketPlayerBlockPlacement.func_148833_a(C08PacketPlayerBlockPlacement.java:109) ~[jo.class:?]
        at net.minecraft.network.NetworkManager.func_74428_b(NetworkManager.java:244) ~[ej.class:?]
        at net.minecraft.network.NetworkSystem.func_151269_c(NetworkSystem.java:178) ~[nc.class:?]
        at net.minecraft.server.MinecraftServer.func_71190_q(MinecraftServer.java:865) ~[MinecraftServer.class:?]
        at net.minecraft.server.dedicated.DedicatedServer.func_71190_q(DedicatedServer.java:349) ~[lt.class:?]
        at net.minecraft.server.MinecraftServer.func_71217_p(MinecraftServer.java:705) ~[MinecraftServer.class:?]
        at net.minecraft.server.MinecraftServer.run(MinecraftServer.java:591) ~[MinecraftServer.class:?]
        at java.lang.Thread.run(Thread.java:750) ~[?:1.8.0_392]

@Dream-Master Dream-Master requested a review from a team March 16, 2024 21:48
@Dream-Master
Copy link
Member

Ordnungsgemäße Trennung in Server und Client. Sonst geht die Logik verloren, wenn "!world.isRemote" ein Paket an den Server sendet... Es bringt den Server zum Absturz.

Proper separation for server and client. Otherwise the logic is lost when "!world.isRemote" sends a packet to the server... it crashes the server.

Danke für den fix. Mach die Prs/issues bitte immer auf englisch wir sind international unterwegs :) Ich frag gerade mal nach einem review.

@Dream-Master Dream-Master merged commit 79f601c into GTNewHorizons:master Mar 24, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants