Fixed sync issue with Raven Kama glide toggle #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
OneEyeMaker
approved these changes
Jun 8, 2024
|
I swear to god I approved this exact PR a couple days ago, wtf |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13116
Because movement is client-authoritative in Minecraft and toggling the Raven Kama changes its server-side state, the toggle would not propagate to actually change movement. This did not affect the Raven Cloak because Traveller's Gear handles its own slots differently than Baubles does. Baubles inventory screen is created from the serverside ItemStacks, hence item appeared synced even though it wasn't.
Fixed by syncing the Baubles inventory belt slot when the Raven Kama is toggled.