Thaumic boots dep + compat #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alastors
suggested changes
Nov 13, 2024
src/main/java/witchinggadgets/common/items/armor/ItemPrimordialArmor.java
Show resolved
Hide resolved
src/main/java/witchinggadgets/common/items/armor/ItemPrimordialArmor.java
Show resolved
Hide resolved
|
I know this opinion doesnt matter since I'm not part of the team, however: There are a couple small things to address in my opinion, mostly just maintaining consistency with the previous code like the floating point I highlight, overall it's a great change though and I hope someone gets to this besides me soon. |
NotAPenguin0
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the functionalities of Thaumic Boots (high speed, speed control, jump boost control, inertia cancelling, step assist and omnidirectional mode) to the Primordial Armor Boots, one of the 2 top tier thaumcraft armors.
Also includes an update to the outdated dependencies of this repository and added TB dependency.