-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wirelesshub #24
Wirelesshub #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- drop with color configured thing: you are now using item meta 17 for the hub. just like the non-hub code that already exists here, you can use meta 17~34 for the hub (with 17 as colorless). e..g use
stack.setItemDamage(te.color ==AEColor.Transparent ? 17 : 17 + te.color.ordinal() + 1)
in getDrops() and then set the color like the existing code inonBlockPlacedBy()
- I'd very much prefer to have different texture for hubs. I've sent a request in #texture-dev, but if they are too occupied with other matter, using same texture is also acceptable for now
I like H variant. |
Ready, new texture will be later. God bless soul anyone who will brave enough to do code review.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tested this yet in game, but code changes overall look good. I have just a few comments
src/main/scala/net/bdew/ae2stuff/machines/wireless/TileWireless.scala
Outdated
Show resolved
Hide resolved
I know is just QoL, but is not the recipe like very simple? |
Yea if the recipe match a bit more with other ae and addons mods I am happy @lordIcocain |
Alright, i removed in mod recipe. |
Tested this out in game finally and all the controls seem good, everything seems to work properly. However, Light Blue and Yellow wireless hub textures seem to be flipped. Also the pink one is a very different color from normal pink wireless |
These seem to only be flipped in the inventory model, not when placed in-world. Also, I think the fluix texture should be more like the standard wireless and have no coloration to it when placed. A couple others seem to have colors that don't quite line up like pink, but not as severe (light blue, cyan) |
I uploaded fix for colors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, everything looks great now
Hub -> Hub = NO
Wireless -> Hub = OK
Wireless <- Hub = Wireless -> Hub
Not use power, should require Neutronium cell in recipe. (i can change)Pick up only with wrench. idk how set meta when break. no color pick up.Looks same as Wireless.Closes GTNewHorizons/GT-New-Horizons-Modpack#14729
upd.
Added custom texture and color pickup.
Added power usage, sum power usage of connected wireless.
Added recipe.
Added qols in adv tools for working with hub.
Added ability to clear adv tool queue.