Arnold ShaderNetworkAlgo : Add attributeName argument to SubstitutionFunction
#6214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onFunction This provides the name of the attribute from which the target ShaderNetwork was retrieved. This is an ABI break, which we would never normally contemplate in a minor release. But we only introduced the API in the previous version, and we have determined that without this change it is not fit for purpose. Full backwards compatibility can't be provided without significant overhead and additional fragility, and nor can we wait for a major version to make this change. The purpose of the ABI guarantee is to prevent breakage, but in this case we believe breakage to be vanishingly unlikely, due to the recency of introduction and esoteric nature of the API. So, we are permitting ourselves this one exception in the belief that it does no harm.
murraystevenson
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides the name of the attribute from which the target ShaderNetwork was retrieved. This is an ABI break, which we would never normally contemplate in a minor release. But we only introduced the API in the previous version, and we have determined that without this change it is not fit for purpose. Full backwards compatibility can't be provided without significant overhead and additional fragility, and nor can we wait for a major version to make this change. The purpose of the ABI guarantee is to prevent breakage, but in this case we believe breakage to be vanishingly unlikely, due to the recency of introduction and esoteric nature of the API. So, we are permitting ourselves this one exception in the belief that it does no harm.