Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevOps Clean up #14

Merged
merged 6 commits into from
Aug 9, 2023
Merged

DevOps Clean up #14

merged 6 commits into from
Aug 9, 2023

Conversation

noklam
Copy link
Collaborator

@noklam noklam commented Aug 9, 2023

Description

Why was this PR created?

Development notes

What have you changed, and how has this been tested?

  • Replace linters with ruff
  • Create the Makefile alias

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2266b92) 100.00% compared to head (26ed45d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #14   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            3         3           
  Lines           52        52           
=========================================
  Hits            52        52           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noklam noklam merged commit a35e978 into main Aug 9, 2023
8 of 9 checks passed
@noklam
Copy link
Collaborator Author

noklam commented Aug 9, 2023

Free feel to adjust the linting rule - I have set the rules so it is almost identical to what the original tool does, it is much faster but not significant at this point.

Comment on lines -20 to -24
- repo: https://github.com/asottile/blacken-docs
rev: v1.12.1
hooks:
- id: blacken-docs
additional_dependencies: [black==23.3.0]
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@noklam I know the PR is closed but are you sure ruff replace blacken-docs? This is a pre-commit to check black formatting for markdown file, so I think it it unrelated to other changes. I will restore it on the other PR if you agree?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oversight - feel free to restore this one.

@@ -0,0 +1,9 @@
lint:
pre-commit run -a --hook-stage manual $(hook)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the difference with only pre-commit run -a?

@Galileo-Galilei Galileo-Galilei deleted the feat/devops branch September 2, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants