Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove print statement and add linting #45

Merged
merged 10 commits into from
Sep 20, 2023

Conversation

noklam
Copy link
Collaborator

@noklam noklam commented Sep 20, 2023

Description

Why was this PR created?
Fix #44

Development notes

What have you changed, and how has this been tested?

  • Add dummy migration.md to prevent linkcheck fails
  • remove print statement
  • Change ruff setting to pick up print in the future

Checklist

  • Read the contributing guidelines
  • Open this PR as a 'Draft Pull Request' if it is work-in-progress
  • Update the documentation to reflect the code changes
  • Add a description of this change and add your name to the list of supporting contributions in the CHANGELOG.md file. Please respect Keep a Changelog guidelines.
  • Add tests to cover your changes

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

  • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.

  • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorised to submit this contribution on behalf of the original creator(s) or their licensees.

  • I certify that the use of this contribution as authorised by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11% ⚠️

Comparison is base (a631c1a) 89.21% compared to head (fa7842c) 89.10%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
- Coverage   89.21%   89.10%   -0.11%     
==========================================
  Files           5        5              
  Lines         102      101       -1     
==========================================
- Hits           91       90       -1     
  Misses         11       11              
Files Changed Coverage Δ
kedro_pandera/framework/config/resolvers.py 100.00% <ø> (ø)
kedro_pandera/framework/hooks/pandera_hook.py 57.69% <ø> (ø)
kedro_pandera/framework/cli/cli.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noklam
Copy link
Collaborator Author

noklam commented Sep 20, 2023

Fix a few small things hopefully it will all pass now.

@noklam
Copy link
Collaborator Author

noklam commented Sep 20, 2023

the apache2.0 link is still failing for no reason, the link works perfectly fine.

@noklam noklam merged commit 315073e into main Sep 20, 2023
8 of 9 checks passed
@Galileo-Galilei
Copy link
Owner

The apache 2 often fails randomly, I think this is due to a kind or DDOS protection. Nothing to worry about.

Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove leftover print statement in resolve_dataframe_model
2 participants