Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AES cleanup fixes pt 3 issue 179 #237

Merged
merged 6 commits into from
Feb 14, 2025
Merged

AES cleanup fixes pt 3 issue 179 #237

merged 6 commits into from
Feb 14, 2025

Conversation

jn80842
Copy link
Contributor

@jn80842 jn80842 commented Feb 4, 2025

Remaining small fixes from issue 179

Copy link
Contributor

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! One return type I think needs to change but otherwise excellent.

Primitive/Symmetric/Cipher/Block/AES/ExpandKey.cry Outdated Show resolved Hide resolved
Primitive/Symmetric/Cipher/Block/AES/Cipher.cry Outdated Show resolved Hide resolved
Copy link
Contributor

@marsella marsella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing, looks good!

@jn80842 jn80842 merged commit 1cf0a9d into master Feb 14, 2025
2 checks passed
@jn80842 jn80842 deleted the smallAES179a branch February 14, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants