Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Game Lobby Display and Quick Join Feature #409

Merged
merged 2 commits into from
Oct 13, 2024

Conversation

JohnsonMao
Copy link
Contributor

Why need this change? / Root cause:

  • 逐步調整到符合設計稿與使用者流程

Changes made:

  • 大廳頁
  • 按鈕新增樣式
  • 快速加入遊戲功能
  • 底層樣式重構

Test Scope / Change impact:

  • none

Issue

@JohnsonMao JohnsonMao self-assigned this Oct 13, 2024
@github-actions github-actions bot added the refactor refactor the changes already merged. label Oct 13, 2024
@JohnsonMao JohnsonMao force-pushed the refactor/home-page branch 2 times, most recently from e0ccb96 to f3f58da Compare October 13, 2024 11:36
Copy link

sonarcloud bot commented Oct 13, 2024

@GaaSBot
Copy link

GaaSBot commented Oct 13, 2024

Knip Scan Result for 7df9d6d

Unused files (7)
Unused files (7)
.bundlewatch.config.js
components/shared/Footer.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exported types (3)
Unused exported types (3)
ChatProps type components/shared/Chat/v2/Chat.tsx
ChatHeaderProps type components/shared/Chat/v2/ChatHeader.tsx
RoomEntryError type requests/rooms/index.ts
Unused exported types in namespaces (1)
Unused exported types in namespaces (1)
BaseBoxFancyProp interface components/shared/BoxFancy/BoxFancy.tsx
Unused exported enum members (1)
Unused exported enum members (1)
PRIMARY_TRANSPARENT ButtonVariant components/shared/Button/v2/Button.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Oct 13, 2024

🤖 Lighthouse Scan Result for 7df9d6d

/rooms
Metric Value
Performance 68
Seo 78
Accessibility 78
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 59
Seo 80
Accessibility 85
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 73
Seo 78
Accessibility 94
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit ce8f7c9 into main Oct 13, 2024
7 checks passed
@JohnsonMao JohnsonMao deleted the refactor/home-page branch October 13, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor refactor the changes already merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants