Change Method Name in app/repositories/RoomRepository.java

Game-as-a-Service · Aug 15, 2023 · b01abd4 · b01abd4
1 parent 5ce62bf
commit b01abd4
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...ckend/app/src/main/java/tw/waterballsa/gaas/citadels/app/repositories/RoomRepository.java b/...ckend/app/src/main/java/tw/waterballsa/gaas/citadels/app/repositories/RoomRepository.java
@@ -4,6 +4,6 @@
 import java.util.Optional;
 
 public interface RoomRepository {
-    Optional<Room> save(Room room);
-    Optional<Room> findById(String gameId);
+    Optional<Room> createRoom(Room room);
+    Optional<Room> findRoomById(String gameId);
 }
diff --git a/.../backend/app/src/main/java/tw/waterballsa/gaas/citadels/app/usecases/JoinRoomUsecase.java b/.../backend/app/src/main/java/tw/waterballsa/gaas/citadels/app/usecases/JoinRoomUsecase.java
@@ -21,12 +21,12 @@ public void execute(Request request, Presenter presenter) {
         Room room = findRoomById(request.getRoomId());
         User user = new User(request.getUserName(), request.getUserImage());
         room.joinUser(user);
-        roomRepository.save(room);
+        roomRepository.createRoom(room);
         presenter.present(room);
     }
 
     private Room findRoomById(String roomId) {
-        Optional<Room> room = roomRepository.findById(roomId);
+        Optional<Room> room = roomRepository.findRoomById(roomId);
         return room.orElseThrow(() -> new NullPointerException("CAN NOT FIND GAME, ID=" + roomId));
     }
 

diff --git a/...ng/src/main/java/tw/waterballsa/gaas/citadels/spring/repositories/RoomRepositoryImpl.java b/...ng/src/main/java/tw/waterballsa/gaas/citadels/spring/repositories/RoomRepositoryImpl.java
@@ -16,13 +16,13 @@ public class RoomRepositoryImpl implements RoomRepository {
     private final RoomDAO roomDAO;
 
     @Override
-    public Optional<Room> save(Room room) {
+    public Optional<Room> createRoom(Room room) {
         RoomData data = RoomData.toData(room);
         return Optional.ofNullable(roomDAO.save(data).toDomain());
     }
 
     @Override
-    public Optional<Room> findById(String gameId) {
+    public Optional<Room> findRoomById(String gameId) {
         return roomDAO.findById(gameId).map(RoomData::toDomain);
     }
 }
diff --git a/...end/spring/src/test/java/tw/waterballsa/gaas/citadels/spring/CitadelsApplicationTest.java b/...end/spring/src/test/java/tw/waterballsa/gaas/citadels/spring/CitadelsApplicationTest.java
@@ -30,11 +30,11 @@ public abstract class CitadelsApplicationTest {
     private RoomRepository roomRepository;
 
     protected Room givenGameStarted(String name, User holder, User... users) {
-        return roomRepository.save(new Room(name, holder, asList(users))).orElseThrow();
+        return roomRepository.createRoom(new Room(name, holder, asList(users))).orElseThrow();
     }
 
     protected Room findRoomById(String roomId) {
-        return roomRepository.findById(roomId).orElseThrow(() -> new JoinRoomException("CAN NOT FIND ROOM ID=" + roomId));
+        return roomRepository.findRoomById(roomId).orElseThrow(() -> new JoinRoomException("CAN NOT FIND ROOM ID=" + roomId));
     }
 
     protected User findUserByName(String roomId, String name) {