Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename url and revise createRoom test #100

Closed
wants to merge 1 commit into from

Conversation

snowmancc
Copy link
Collaborator

No description provided.

@SneakyThrows
private ResultActions createRoom(CreateRoomUseCase.Request createRoomRequest) {
return mockMvc.perform(post(API_PREFIX + "/game")
private ResultActions createRoom(RoomController.CreateRoomRequest createRoomRequest) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

要把 room 相關的 api 都放在 RoomController 嗎 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好呀

Copy link
Collaborator

@timt1028 timt1028 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@snowmancc snowmancc closed this Aug 22, 2023
@snowmancc snowmancc deleted the backend/refactor_create_game branch September 2, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants