feat(settings): add method that saves settings to file

[SrGesus]

Description

Include a summary of the changes here.

Checklist

• Self-review changes.
• Evaluate impact on the documentation.
• Ensure test coverage.
• Write new samples.
• Add entry to the changelog's unreleased section.

[github-actions]

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1362/
on branch gh-pages at 2024-11-29 17:11 UTC

[codecov]

Codecov Report

Attention: Patch coverage is 48.38710% with 32 lines in your changes missing coverage. Please review.

Project coverage is 53.43%. Comparing base (99302b3) to head (a0a4782).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
engine/src/settings/settings.cpp	46.55%	31 Missing ⚠️
engine/src/settings/plugin.cpp	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
- Coverage   53.47%   53.43%   -0.04%     
==========================================
  Files         451      451              
  Lines       25802    25827      +25     
  Branches     2386     2390       +4     
==========================================
+ Hits        13797    13801       +4     
- Misses      12005    12026      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[RiscadoA]

If we do end up reimplementing the settings resource as a system argument, this would no longer be necessary 🤔
You could just have a Settings::save method, which ig would be even better because then you don't need to mess with the weird event system we have and it is also synchronous. Opinions?

[SrGesus]

I think we wanted events to be able to do something if a setting changes, e.g reload graphics if you change a graphics setting or something and there we will need to use something similar if not events (like an observer idk).
But yes for saving i don't need events, in fact i can do it without events without reimplementing settings

[RiscadoA]

I think we wanted events to be able to do something if a setting changes, e.g reload graphics if you change a graphics setting or something and there we will need to use something similar if not events (like an observer idk). But yes for saving i don't need events, in fact i can do it without events without reimplementing settings

Yeah on that case I agree that we should have an event. But yeah, here I think it's probably best to keep the 'save trigger' as a method only. I don't see a use case for the event rn

[RiscadoA]

Thanks for working on this! I would just simplify this a bit before merging.
Also, don't forget the changelog entry 😌

[RiscadoA]

Accidentally dismissed my own review, my bad

[diogomsmiranda]

What is the status on this? Is this ready for review?

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[SrGesus]

What is the status on this? Is this ready for review?

The settings part should be done now. I just intend on adding a few tests and the changelog.

[github-actions]

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

[RiscadoA]

Other than the comments I pointed out, LGTM!

[RiscadoA]

Also don't forget to update the CHANGELOG!

[diogomsmiranda]

LGTM!