-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add point light shadows #1366
Add point light shadows #1366
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
- Coverage 53.70% 53.47% -0.24%
==========================================
Files 450 451 +1
Lines 25691 25802 +111
Branches 2375 2386 +11
==========================================
Hits 13797 13797
- Misses 11894 12005 +111 ☔ View full report in Codecov by Sentry. |
5008557
to
a83b9c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good work on this 🚀 👀 that was quick
Other than the comments I added, I feel like it would be a good idea to split the shadow atlas resource and plugin into two if you implement it like this.
The code is already quite complex as it is, and with this you're essentially merging two different rendering phases into a single one. It would be simpler to read and understand if they were separate, I think.
Maybe a spot_shadow_atlas
and a point_shadow_atlas
? Or should we keep it as is?
e6f64e1
to
615addf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
f9b9304
to
f5f8920
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
f5f8920
to
2eccc83
Compare
b488733
to
939c533
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
Uniform PerScene is becoming larger than the max limit in some GPUs
939c533
to
cf69124
Compare
Description
Implements shadows for point lights.
Checklist