Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SSAO optional #1397

Merged
merged 1 commit into from
Dec 14, 2024
Merged

Make SSAO optional #1397

merged 1 commit into from
Dec 14, 2024

Conversation

tomas7770
Copy link
Contributor

Description

Changes deferred shading to work without SSAO. If the SSAO component isn't present in the render target, the feature is disabled.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.
  • Add entry to the changelog's unreleased section.

@tomas7770 tomas7770 linked an issue Dec 1, 2024 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Dec 1, 2024

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1397/
on branch gh-pages at 2024-12-01 19:51 UTC

@tomas7770 tomas7770 added this to the 0.6 milestone Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 53.42%. Comparing base (9d530fe) to head (b6c828d).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
engine/src/render/deferred_shading/plugin.cpp 0.00% 4 Missing ⚠️
engine/src/render/defaults/plugin.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1397      +/-   ##
==========================================
- Coverage   53.43%   53.42%   -0.01%     
==========================================
  Files         462      462              
  Lines       25850    25854       +4     
  Branches     2389     2391       +2     
==========================================
  Hits        13813    13813              
- Misses      12037    12041       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomas7770 tomas7770 marked this pull request as ready for review December 1, 2024 20:25
@tomas7770 tomas7770 requested review from RiscadoA and a team as code owners December 1, 2024 20:25
@tomas7770 tomas7770 requested review from mkuritsu, Scarface1809 and diogomsmiranda and removed request for a team and diogomsmiranda December 1, 2024 20:25
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This turned out simple, great 👀 ty for working on it!

Copy link
Contributor

@mkuritsu mkuritsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tomas7770 tomas7770 merged commit 395ff0d into main Dec 14, 2024
12 checks passed
@tomas7770 tomas7770 deleted the 1396-make-ssao-optional branch December 14, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make SSAO optional
4 participants