Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add audio sample page #1421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: add audio sample page #1421

wants to merge 1 commit into from

Conversation

diogomsmiranda
Copy link
Contributor

@diogomsmiranda diogomsmiranda commented Dec 16, 2024 •
edited
Loading

Description

Add the link for the audio sample page.

@diogomsmiranda diogomsmiranda requested review from RiscadoA and a team as code owners December 16, 2024 23:49
@diogomsmiranda diogomsmiranda linked an issue Dec 16, 2024 that may be closed by this pull request
Create page.md for audio sample #1392
Open
@diogomsmiranda diogomsmiranda requested review from RodrigoVintem and removed request for a team December 16, 2024 23:49
@github-actions github-actions bot added A-Engine B-Audio C-Documentation P-Urgent This issue is a big priority, and it would be good to close it ASAP labels Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 16, 2024 •
edited
Loading

PR Preview Action v1.4.8
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/preview/pr-1421/
on branch gh-pages at 2024-12-26 13:14 UTC

@codecov Codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.43%. Comparing base (395ff0d) to head (9d16ac9).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   53.42%   53.43%           
=======================================
  Files         462      462           
  Lines       25854    25854           
  Branches     2391     2391           
=======================================
+ Hits        13813    13814    +1     
+ Misses      12041    12040    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA requested a review from a team December 17, 2024 07:43
RiscadoA
RiscadoA previously requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM but the source code references in the sample page are also broken.
Pls fix that before merging

@diogomsmiranda diogomsmiranda force-pushed the 1392-create-pagemd-for-audio-sample branch from 9704c40 to 9d16ac9 Compare December 26, 2024 13:13
@diogomsmiranda diogomsmiranda dismissed RiscadoA’s stale review December 26, 2024 13:15

Fixed with the requested changes.

RodrigoVintem
RodrigoVintem approved these changes Dec 29, 2024
View reviewed changes
Copy link
Contributor

@RodrigoVintem RodrigoVintem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RodrigoVintem RodrigoVintem RodrigoVintem approved these changes

@RiscadoA RiscadoA RiscadoA left review comments

At least 3 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
A-Engine B-Audio C-Documentation P-Urgent This issue is a big priority, and it would be good to close it ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create page.md for audio sample
3 participants
@diogomsmiranda @RiscadoA @RodrigoVintem