Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Deserializer #767

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Add Deserializer #767

merged 2 commits into from
Nov 10, 2023

Conversation

RiscadoA
Copy link
Member

@RiscadoA RiscadoA commented Nov 3, 2023

Description

Adds the Deserializer base class.

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage. (will be covered in tests of its implementations)
  • Write new samples.

@RiscadoA RiscadoA added this to the 0.0.2 DevGamm milestone Nov 3, 2023
@RiscadoA RiscadoA self-assigned this Nov 3, 2023
@RiscadoA RiscadoA linked an issue Nov 3, 2023 that may be closed by this pull request
Copy link
Contributor

github-actions bot commented Nov 3, 2023

PR Preview Action v1.4.4
🚀 Deployed preview to https://GameDevTecnico.github.io/cubos/docs-preview/pr-767/
on branch gh-pages at 2023-11-10 12:36 UTC

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Attention: 13 lines in your changes are missing coverage. Please review.

Comparison is base (0fb3cd0) 40.52% compared to head (15cd302) 40.41%.

❗ Current head 15cd302 differs from pull request most recent head 9aefb17. Consider uploading reports for the commit 9aefb17 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #767      +/-   ##
==========================================
- Coverage   40.52%   40.41%   -0.11%     
==========================================
  Files         104      105       +1     
  Lines        6821     6839      +18     
==========================================
  Hits         2764     2764              
- Misses       4057     4075      +18     
Files Coverage Δ
core/src/cubos/core/data/des/deserializer.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch 2 times, most recently from fd77cd4 to 47719eb Compare November 3, 2023 17:10
@RiscadoA RiscadoA enabled auto-merge (rebase) November 3, 2023 17:17
@RiscadoA RiscadoA mentioned this pull request Nov 4, 2023
4 tasks
@RiscadoA RiscadoA disabled auto-merge November 4, 2023 15:07
@RiscadoA RiscadoA removed the request for review from luishfonseca November 4, 2023 15:07
@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch from 47719eb to 55ca1e2 Compare November 4, 2023 15:26
@RiscadoA RiscadoA added the S-Blocked Blocked on another issue or PR label Nov 4, 2023
@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch 2 times, most recently from fda61ab to 9dc85ef Compare November 4, 2023 15:46
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ clang-tidy found issue(s) with the introduced code (1/1)

core/samples/data/des/custom/main.cpp Show resolved Hide resolved
@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch 2 times, most recently from a756bb4 to 6e28bc0 Compare November 4, 2023 15:52
@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch 2 times, most recently from 2c132f6 to 17c2e6a Compare November 9, 2023 11:58
@RiscadoA RiscadoA enabled auto-merge (rebase) November 9, 2023 11:58
@RiscadoA RiscadoA removed the S-Blocked Blocked on another issue or PR label Nov 9, 2023
@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch from 17c2e6a to 9fede47 Compare November 10, 2023 12:09
@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch from 093801f to be1b8d9 Compare November 10, 2023 12:15
@RiscadoA
Copy link
Member Author

Using this as testing grounds for the clang-tidy fix

@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch 2 times, most recently from f42b80f to c2142b8 Compare November 10, 2023 12:32
@RiscadoA RiscadoA force-pushed the 568-add-deserializer branch from c2142b8 to 9aefb17 Compare November 10, 2023 12:35
@RiscadoA RiscadoA disabled auto-merge November 10, 2023 12:35
@RiscadoA RiscadoA merged commit 0fa75e0 into main Nov 10, 2023
7 checks passed
@RiscadoA RiscadoA deleted the 568-add-deserializer branch November 10, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Deserializer
2 participants