Remove old serialization code from SceneBridge
#775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RiscadoA
force-pushed
the
773-remove-old-serialization-code-from-scenebridge
branch
from
a59e137 to
8ca77d6
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #775 +/- ##
==========================================
- Coverage 41.79% 41.69% -0.10%
==========================================
Files 108 108
Lines 7005 6993 -12
==========================================
- Hits 2928 2916 -12
Misses 4077 4077 ☔ View full report in Codecov by Sentry. |
RiscadoA
force-pushed
the
773-remove-old-serialization-code-from-scenebridge
branch
from
8ca77d6 to
352d155
Compare
1 task
RiscadoA
force-pushed
the
773-remove-old-serialization-code-from-scenebridge
branch
from
352d155 to
937ce61
Compare
RiscadoA
force-pushed
the
773-remove-old-serialization-code-from-scenebridge
branch
from
937ce61 to
a02d4e1
Compare
roby2014
requested changes
Nov 18, 2023
RiscadoA
force-pushed
the
773-remove-old-serialization-code-from-scenebridge
branch
from
a02d4e1 to
0d53043
Compare
roby2014
approved these changes
Nov 18, 2023
RiscadoA
deleted the
773-remove-old-serialization-code-from-scenebridge
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes the ECS use the actual type name to identify components instead of the attribute name - still haven't removed it from quadrados, but the whole attribute will soon go away anyway.
Changes the
SceneBridgeto use the newJSONDeserializerinstead of the old one.Checklist
Ensure test coverage.