Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate DataInspector and remove old imgui serialization #785

Merged
merged 4 commits into from
Nov 18, 2023
Merged

Integrate DataInspector and remove old imgui serialization #785

merged 4 commits into from
Nov 18, 2023

Conversation

roby2014
Copy link
Member

@roby2014 roby2014 commented Nov 9, 2023 •
edited
Loading

Blocked by #779

Description

Related to #748

  • Removed old serialization methods
  • Refactor entity inspector + settings inspector plugins to use the new DataInspector
  • Add settings inspector to tesseratos sample

Checklist

  • Self-review changes.
  • Evaluate impact on the documentation.
  • Ensure test coverage.
  • Write new samples.

@roby2014 roby2014 added A-Engine B-Tools B-Reflection S-Blocked Blocked on another issue or PR labels Nov 9, 2023
@roby2014 roby2014 changed the title Integrate DataInspector and remove old serialization method Integrate DataInspector and remove old imgui serialization method Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023 •
edited
Loading

PR Preview Action v1.4.4
Preview removed because the pull request was closed.
2023-11-18 10:10 UTC

@codecov Codecov
Copy link

codecov bot commented Nov 9, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70655b4) 41.74% compared to head (0ab41d1) 41.74%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #785   +/-   ##
=======================================
  Coverage   41.74%   41.74%           
=======================================
  Files         107      107           
  Lines        6998     6998           
=======================================
  Hits         2921     2921           
  Misses       4077     4077

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@roby2014 roby2014 changed the title Integrate DataInspector and remove old imgui serialization method Integrate DataInspector and remove old imgui serialization Nov 9, 2023
@roby2014 roby2014 marked this pull request as draft November 9, 2023 08:43
@roby2014 roby2014 force-pushed the fix-entity-inspector-plugin-with-dataresource branch 2 times, most recently from 5bf7fbd to 9787d82 Compare November 13, 2023 05:21
github-actions[bot]
github-actions bot requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/2)

engine/include/cubos/engine/imgui/data_inspector.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/imgui/data_inspector.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/imgui/data_inspector.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/imgui/data_inspector.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/imgui/data_inspector.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/imgui/data_inspector.cpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/imgui/data_inspector.cpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/data_inspector.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/data_inspector.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/data_inspector.hpp Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot previously requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (2/2)

tools/tesseratos/src/tesseratos/plugin.cpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/data_inspector.hpp Outdated Show resolved Hide resolved
engine/include/cubos/engine/imgui/data_inspector.hpp Outdated Show resolved Hide resolved
@roby2014 roby2014 force-pushed the fix-entity-inspector-plugin-with-dataresource branch 4 times, most recently from dd25501 to 719417f Compare November 13, 2023 05:31
@roby2014 roby2014 marked this pull request as ready for review November 13, 2023 05:31
RiscadoA
RiscadoA requested changes Nov 13, 2023
View reviewed changes
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this too @roby2014! So happy to see all of those old:: things going away 😭

tools/tesseratos/src/tesseratos/entity_inspector/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/entity_inspector/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/entity_inspector/plugin.cpp Show resolved Hide resolved
tools/tesseratos/src/tesseratos/entity_inspector/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/entity_inspector/plugin.cpp Show resolved Hide resolved
tools/tesseratos/src/tesseratos/entity_inspector/plugin.cpp Outdated Show resolved Hide resolved
tools/tesseratos/src/tesseratos/settings_inspector/plugin.cpp Outdated Show resolved Hide resolved
@roby2014 roby2014 force-pushed the fix-entity-inspector-plugin-with-dataresource branch 2 times, most recently from bd61ff8 to 91b5047 Compare November 13, 2023 14:05
@roby2014 roby2014 requested a review from RiscadoA November 13, 2023 14:32
@roby2014 roby2014 force-pushed the fix-entity-inspector-plugin-with-dataresource branch from 91b5047 to 423e5c3 Compare November 13, 2023 22:48
@roby2014 roby2014 removed the S-Blocked Blocked on another issue or PR label Nov 13, 2023
@roby2014 roby2014 force-pushed the fix-entity-inspector-plugin-with-dataresource branch from 423e5c3 to 0ab41d1 Compare November 18, 2023 09:56
@roby2014 roby2014 merged commit 14e0b8c into main Nov 18, 2023
@roby2014 roby2014 deleted the fix-entity-inspector-plugin-with-dataresource branch November 18, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RiscadoA RiscadoA RiscadoA approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

@DiogoMendonc-a DiogoMendonc-a Awaiting requested review from DiogoMendonc-a

@luishfonseca luishfonseca Awaiting requested review from luishfonseca

Assignees

@roby2014 roby2014

Labels
A-Engine B-Reflection B-Tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roby2014 @RiscadoA