Emit Collision Events #804
Merged
+81
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luishfonseca
force-pushed
the
collision-events
branch
from
e9562cc to
2d6597c
Compare
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #804 +/- ##
=======================================
Coverage 40.41% 40.41%
=======================================
Files 105 105
Lines 6839 6839
=======================================
Hits 2764 2764
Misses 4075 4075 ☔ View full report in Codecov by Sentry. |
RiscadoA
approved these changes
Nov 12, 2023
There was a problem hiding this comment.
Thanks for working on this! Will be really cool if we can integrate this with physics for the demo @fallenatlas 👀
luishfonseca
force-pushed
the
collision-events
branch
from
2d6597c to
158eff7
Compare
RiscadoA
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Emits AABB collision events, an hack just for DevGamm. This should eventually be redesigned once narrow phase is implemented.