Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ring gizmo #881

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Add ring gizmo #881

merged 1 commit into from
Jan 31, 2024

Conversation

DiogoMendonc-a
Copy link
Contributor

No description provided.

@DiogoMendonc-a DiogoMendonc-a linked an issue Jan 12, 2024 that may be closed by this pull request
@DiogoMendonc-a DiogoMendonc-a self-assigned this Jan 12, 2024
@github-actions github-actions bot added the S-Triage Issues whose priority still has to be figured out label Jan 12, 2024
Copy link
Contributor

github-actions bot commented Jan 12, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-01-31 21:24 UTC

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/gizmos/types/ring.hpp Show resolved Hide resolved
engine/src/cubos/engine/gizmos/types/ring.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/gizmos/types/ring.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/gizmos/types/ring.hpp Show resolved Hide resolved
engine/src/cubos/engine/gizmos/types/ring.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/gizmos/types/ring.hpp Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bce7c5) 49.68% compared to head (dba089a) 49.68%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage   49.68%   49.68%           
=======================================
  Files         134      134           
  Lines        8009     8009           
=======================================
  Hits         3979     3979           
  Misses       4030     4030           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

engine/src/cubos/engine/gizmos/types/ring.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/gizmos/types/ring.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/gizmos/types/ring.hpp Outdated Show resolved Hide resolved
engine/src/cubos/engine/gizmos/types/ring.hpp Outdated Show resolved Hide resolved
Copy link
Member

@RiscadoA RiscadoA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DiogoMendonc-a DiogoMendonc-a merged commit dac8150 into main Jan 31, 2024
10 checks passed
@DiogoMendonc-a DiogoMendonc-a deleted the 877-add-ring-gizmo branch January 31, 2024 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Engine B-Gizmos S-Triage Issues whose priority still has to be figured out
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ring Gizmo
2 participants