Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the Twitter logo #1022

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Changed the Twitter logo #1022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,12 +1190,12 @@ <h3>Support</h3>
<h3>Connect With Us</h3>
<div class="social-icons">
<a href="https://www.facebook.com/"><i class="fab fa-facebook-f"></i></a>
<a href="https://x.com/?lang=en"><i class="fab fa-twitter"></i></a>
<a href="https://x.com/?lang=en"><img height="15px" width="20px" src="logo/logo.svg" alt="">
<a href="https://www.linkedin.com/"><i class="fab fa-linkedin-in"></i></a>
<a href="https://www.instagram.com/"><i class="fab fa-instagram"></i></a>
Comment on lines +1193 to 1195
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Improperly nested and unclosed <img> and <a> tags in social icons

At line 1193, the <img> tag inside the <a> tag is not properly closed, and the <a> tag lacks a closing tag. This can break the HTML parsing and affect how browsers display the content.

Apply the following fix:

<a href="https://x.com/?lang=en">
-  <img height="15px" width="20px" src="logo/logo.svg" alt="">
+  <img height="15px" width="20px" src="logo/logo.svg" alt="" />
</a>

Ensure that all <img> tags are self-closed and every <a> tag has a corresponding closing </a> tag.

Committable suggestion skipped: line range outside the PR's diff.

</div>
</div>

</div>
<div class="footer-bottom">

Expand Down Expand Up @@ -1230,7 +1230,7 @@ <h3>Support</h3>
<h3>Connect With Us</h3>
<div class="social-icons">
<a href="#"><i class="fab fa-facebook-f"></i></a>
<a href="#"><i class="fab fa-twitter"></i></a>
<a href="#"><img height="15px" width="20px" src="logo/logo.svg" alt="">
<a href="#"><i class="fab fa-linkedin-in"></i></a>
<a href="#"><i class="fab fa-instagram"></i></a>
Comment on lines +1233 to 1235
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Missing closing tags in footer social icons

Similar to earlier, at line 1233, the <a> and <img> tags are not properly closed. This can lead to rendering issues in the footer section.

Correct the tags as follows:

<a href="#">
-  <img height="15px" width="20px" src="logo/logo.svg" alt="">
+  <img height="15px" width="20px" src="logo/logo.svg" alt="" />
</a>

Repeat this fix for all social icon links to ensure proper HTML structure.

Committable suggestion skipped: line range outside the PR's diff.

</div>
Expand Down Expand Up @@ -1420,7 +1420,7 @@ <h3>Support</h3>
<h3>Connect With Us</h3>
<div class="social-icons">
<a href="#"><i class="fab fa-facebook-f"></i></a>
<a href="#"><i class="fab fa-x-twitter"></i></a>
<a href="#"><img height="15px" width="20px" src="logo/logo.svg" alt="">
<a href="#"><i class="fab fa-linkedin-in"></i></a>
<a href="#"><i class="fab fa-instagram"></i></a>
Comment on lines +1423 to 1425
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Unclosed tags affecting footer layout

At line 1423, there are unclosed <img> and <a> tags within the social icons section, which can disrupt the layout and functionality of the footer.

Apply this correction:

<a href="#">
-  <img height="15px" width="20px" src="logo/logo.svg" alt=""> 
+  <img height="15px" width="20px" src="logo/logo.svg" alt="" />
</a>

Ensure all tags are properly closed to maintain the integrity of the HTML document.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
<a href="#"><img height="15px" width="20px" src="logo/logo.svg" alt="">
<a href="#"><i class="fab fa-linkedin-in"></i></a>
<a href="#"><i class="fab fa-instagram"></i></a>
<a href="#">
<img height="15px" width="20px" src="logo/logo.svg" alt="" />
</a>
<a href="#"><i class="fab fa-linkedin-in"></i></a>
<a href="#"><i class="fab fa-instagram"></i></a>

</div>
Expand Down Expand Up @@ -1531,7 +1531,7 @@ <h3>Support</h3>
<h3>Connect With Us</h3>
<div class="social-icons">
<a href="#"><i class="fab fa-facebook-f"></i></a>
<a href="#"><i class="fab fa-twitter"></i></a>
<a href="#"><img height="15px" width="20px" src="logo/logo.svg" alt="">
<a href="#"><i class="fab fa-linkedin-in"></i></a>
<a href="#"><i class="fab fa-instagram"></i></a>
<a href="https://github.com/GarimaSingh0109/Resum-Resume" target="_blank"><i class="fab fa-github"></i></a>
Comment on lines +1534 to 1537
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Incorrect social icon implementation in footer

At line 1534, the <img> tag within the <a> tag for the social icon is not self-closed, and the <a> tag is missing a closing tag.

Fix the code as shown:

<a href="#">
-  <img height="15px" width="20px" src="logo/logo.svg" alt="">
+  <img height="15px" width="20px" src="logo/logo.svg" alt="" />
</a>

Verify all social media links in the footer are correctly implemented.

Committable suggestion skipped: line range outside the PR's diff.

Expand Down
3 changes: 3 additions & 0 deletions logo/logo.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.