Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system.xml dumper #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

V10lator
Copy link
Contributor

Depends on #20 / #22

This allows for setting a duration which will be needed in further PRs.

Signed-off-by: Thomas Rohloff <[email protected]>
Signed-off-by: Thomas Rohloff <[email protected]>
@GerbilSoft
Copy link
Contributor

GerbilSoft commented Mar 23, 2023

It might be worth reworking the "Dump OTP/SEEPROM" function to be a more general "Dump essential files" function, which would dump OTP, SEEPROM, the various XML files, and maybe some other important files to a directory named using the system serial number. Adding a separate dump screen for each type of file seems like a waste.

Should keep "OTP/SEEPROM" on the main menu entry though, so people know that's where it is. ("Dump OTP/SEEPROM and XML files" maybe?)

@V10lator
Copy link
Contributor Author

The current plan of Jan and me is to add a NAND dumper, too (Jan is currently working on that), then add a dump anything option so people with none working display output can dump with ease.
Not sure how useful it would be to combine OTP/SEEPROM and xml dumping into a single option. In case you don't want too many dumping options on the main menu it might be be more feasible to add a dumping submenu?

@GaryOderNichts any thoughts on this?

@GaryOderNichts
Copy link
Owner

The current plan of Jan and me is to add a NAND dumper, too (Jan is currently working on that), then add a dump anything option so people with none working display output can dump with ease. Not sure how useful it would be to combine OTP/SEEPROM and xml dumping into a single option. In case you don't want too many dumping options on the main menu it might be be more feasible to add a dumping submenu?

@GaryOderNichts any thoughts on this?

I think a dump menu with several suboptions for dumping would be nice.
Could even add a "Dump All" or "Dump Essential" option at the top of the menu to allow easily navigating this without video.
It should be good enough for now though. There's going to be a lot of refactoring, before the next release anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants