Mute mypy errors for "check-code" CI #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to #83, it ensures that "Run typing tests" step does not raises and continues without breaking the validation. This will simplify the validation of our PRs (at least for code formatting), but the analysis will be performed to be able to solve it in parallel. Once #83 will be solved we should reactivate the step (erasing the `continue-on-error` directive)
|
@XaviTorello you can close #82 here by changing |
francescarpi
approved these changes
Oct 14, 2020
|
Thanks @XaviTorello ! |
ytturi
pushed a commit
that referenced
this pull request
Oct 14, 2020
Mute mypy errors for "check-code" CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #83, it ensures that "Run typing tests" step does not raises and continues without breaking the validation.
This will simplify the validation of other PRs (at least for code formatting).
The analysis will be performed to be able to review issues and solve it in parallel.
Once #83 will be solved we should reactivate the step (erasing the
continue-on-errordirective)This will avoid this errors:
Code formating
The code has to be well formatted following the formatting rules. For example in Python the code has to follow the PEP8.
Before create your PR, please make sure your code is formatted running:
$ >> black --exclude=venv,__pycache__ ./