-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windbarbs supplement #7808
Windbarbs supplement #7808
Conversation
Things to do: Compare with psxy and note there needs to be changes to:
|
It does
It does, and I made several changes too. It now builds without need to set anything in |
Ok I just browsed the code on GitHub and that used GMT_Message. Will try tomorrow |
When you try, change the mode to +x of the two sh examples to stop that |
Done, but unless you have uncommitted changes, there is no use of GMT_Usage in these codes etc. |
And since this is a branch: Given how all the other supplements are (all "required" together) you should places those tests and rst in their final places now, i.e, test/windbarb/yourwtoscripts and in rst/source/supplements/windbarg and so on. It is OK to not have PS files from the test so far so no worries about dvc. |
I just copied his 2 shell examples. They are not tests.
They are already in |
I don't even know how to use them. I find it to much pain for no gain. |
Dear all,
Regarding test scripts, I rewrite the example scripts *barb_example.sh, and put them into test/windbarbs/ subdirectory on my private repository masahigaki/gmt@e6cb3f6 I would appreciate if you could examine the changes. |
Hi Masakazu, Thanks for that and sorry for not having been more clear. When I said some examples, I was thinking 3 or 4. Just the enough to test the different capabilities (~ps vs grd, with and without a CPT, a 3D case). Not all of them because our test set already takes quite some time to run. The other thing is that we want to avoid having to store the data in our cache system, so we need to generate it for the tests, which your examples already do. I added just one test in this branch to show what I mean. If you could add a minimal set of other representative cases, that would be nice. Joaquim |
Dear Joaquim, Thank you for the clarification and I am sorry for my delayed response. |
I have rewrited {grd,ps,wind}barb.c to use GMT_Usage instead of GMT_Message at masahigaki/gmt@7519afbf . |
Dear Mazakazu, Thank you very much for these contributions. I've integrated them (plus the extra tests) in the official branch. One further thing. We could drop the -T option from |
@PaulWessel I think this is good for merging. |
Remnants of csh in scripts, e.g., \rm. Changed to rm -f
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)Added images
Modified images
Report last updated at commit 14e78f7 |
Think it is ready now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests work, docs look good, -T gone from sight, C-fixes seems fine. Have a look too.
I see that the |
I forgot - will look in < 1 hour |
Had forgotten to do what is also done for psmeca.rst and meca.rst. |
psbarb is fixed |
Ok, let's give this light. |
Thank you very much for fixing the windbarbs code and merging it into master. |
Hi Masakazu, If you have a nice windbarbs map, kind of official looking with meteorological agency logos and so, it would be a nice post in the Forum Showcase |
Hi Masahigaki-san. Thanks for your contribution - we have update some of the code, scripts, and docs to fit with the rest of the supplements. Because of such changes, please be on the lookout for any odd behavior so we can fix it quickly before the upcoming 6.5 release. |
Paul-san, I think "2-D" should be added to
as well as in Line 33 in 74a5caa
Regards, |
Yes, I had already done the update (it is a define statement in the C code) but forgot to run the script that builds those rst includes. Thanks, now updated in master |
This PR contains the code to plot
windbarbs
either from table data as well as two grids,à lá grdvector
.The code was a little reworked from that of https://sites.google.com/site/masahigaki/gmt/gmt-windbarb?authuser=0 with changes to make it compile with GMT master version and drop the complicated plugin recipe.