Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The psl_patch() function is intended for small polygons but it doesn't fill them. #8579

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

joa-quim
Copy link
Member

@joa-quim joa-quim commented Sep 8, 2024

This PR fixes it.

This is what we get. Note that the -G+z is ignored but the segment headers have -Z info

makecpt -T-500/0/20 > cpt.cpt
gmt plot3d D.dat -p217.5/30 -JX15c/10c -Baf -Bza -R253/278/7.6/21.6/-400/-0 -JZ3c -Ccpt.cpt -W+z -G+z -png tri_1.png

tri_1 png

With this PR we get the triangles filled, though we still have to set -L even though the triangles are closed.

gmt plot3d D.dat -p217.5/30 -JX15c/10c -Baf -Bza -R253/278/7.6/21.6/-400/-0 -JZ3c -Ccpt.cpt -G+z -L -png tri_2.png

tri_2 png

D.zip

@joa-quim joa-quim requested a review from a team September 8, 2024 23:07
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blindly approve.

@joa-quim joa-quim merged commit a959fae into master Sep 9, 2024
15 of 18 checks passed
@joa-quim joa-quim deleted the fix-psl_patch branch September 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants