-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fixes #55] Add rootless support for geonode-docker #56
base: master
Are you sure you want to change the base?
Conversation
…, removed some unnecessary code and packages, added rootless capabilities and some good practices)
…docker (Only works on HTTP_HOST: https will be provided with letsencrypt customization);
… - Changed to 8080 and 8443.
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9468526 | Triggered | Generic Password | e98369f | docker/geoserver/docker-compose.yml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Have you checked also the compatibility of the changes with GeoNode Project? |
Yes, but I didn't made a PR yet. I only did it on geonode repo. Look on these mods, this can be applied on geonode-project too |
Related: GeoNode/geonode#12769
Related: #38 |
Thanks @cmotadev for this PR! We didn't have the time to go through it in detail but we will test it and work on it very soon. One of the things you touched (creation of files at build time) is under our radar these days, because the geoserver_data image populating the datadir volume at build time is problematic. It prevents bind mounting the data dir volume, since a bind mounted volume would shadow the datadir content (that is "burnt" at build time). We're going to work on this specific problem in the next few days, so we might need to merge some changes into your PR. |
@giohappy Fell free to do your changes! Now about volues, I think (but not tested yet) that the geoserver_data should be extracted in runtime, not in build time. The trick is, in entrypoint script, to check if the volume exists, mounted and ready []s |
@cmotadev that's what I do in #58 where I also propose to remove the geoserver_data container. |
Great! In addition, I think the nginx and let's encrypt images should be unified - in other words, certbot should be installed on nginx image |
Geonode Docker, now rootless!!!
Objectives
Summary of modifications
General
Geoserver
Geoserver Data
Nginx
Lets Encrypt
Further work