Add pulp_based_impl.py and pulp_impl_test.py #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfisikop
reviewed
Jul 15, 2024
| import math | ||
| import sys | ||
|
|
||
| solver_name = "HiGHS" |
There was a problem hiding this comment.
I think the solver_name should be a function parameter in fba(), fva() etc with default value = "HiGHS"
Then in the unit tests we should call all those functions with default parameter and with "gurobi" (and maybe test more in the future?).
TolisChal
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I have implemented the
fba,fva,inner_ball, andremove_redundant_facetsfunctions using PuLP (the default solver is HiGHS) and have included unit tests to ensure that their behavior remains consistent with the previous implementation.Python packages
pulpandhighspyis required.Unit Test