Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solve issue #83: generate_steady_states fails when you edit a model's optimal percentage twice #83 #90

Closed
wants to merge 1 commit into from

Conversation

rkstu
Copy link
Contributor

@rkstu rkstu commented Mar 3, 2024

Apologies for any confusion—I just realized that I unintentionally deleted the repository (when I was creating a new fork for #89 ) from which I created the initial pull request, resulting in its closure. I've submitted a new pull request to address the same issue(#85). I appreciate your understanding and apologize for any inconvenience caused.
I am still working on this

@vfisikop
Copy link
Contributor

vfisikop commented Apr 3, 2024

Is this PR still active?

@rkstu
Copy link
Contributor Author

rkstu commented Apr 3, 2024

Thanks for checking in! This PR is still active and I'm currently investigating a potential issue with the fast_mmcs function in volestipy.pyx

@rkstu
Copy link
Contributor Author

rkstu commented Apr 26, 2024

I've tried a bunch of different things, I haven't been able to completely fix it yet. The program output keeps acting weird - sometimes executing entirely as expected, but at other times terminating prematurely. This makes me think it might be due to fast_mmcs function in volestipy.pyx. I'm pretty sure that's where the problem is coming from, but deeper understanding of the project is needed to be sure and actually solve it.

@rkstu rkstu closed this by deleting the head repository May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants