Function/is correlation #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h
vfisikop
approved these changes
Jul 5, 2024
| const double tol = 1e-8; | ||
|
|
||
| //check if all the diagonal elements are ones | ||
| for(int i=0 ; i<matrix.rows() ; i++){ |
There was a problem hiding this comment.
please leave one empty space between for and (, similar to if etc
| /// |param[in] matrix | ||
| bool is_correlation_matrix(const MT& matrix){ | ||
|
|
||
| const double tol = 1e-8; |
There was a problem hiding this comment.
This could be a function parameter with default value.
TolisChal
approved these changes
Jul 5, 2024
TolisChal
pushed a commit
that referenced
this pull request
Jul 7, 2024
* new function is_correlation_matrix * update example function call this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h * remove blank line * remove blank line * fix spaces, add function parameter
TolisChal
pushed a commit
that referenced
this pull request
Jul 7, 2024
* new function is_correlation_matrix * update example function call this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h * remove blank line * remove blank line * fix spaces, add function parameter
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 7, 2024
* new function is_correlation_matrix * update example function call this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h * remove blank line * remove blank line * fix spaces, add function parameter
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 7, 2024
* new function is_correlation_matrix * update example function call this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h * remove blank line * remove blank line * fix spaces, add function parameter
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* new function is_correlation_matrix * update example function call this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h * remove blank line * remove blank line * fix spaces, add function parameter
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* new function is_correlation_matrix * update example function call this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h * remove blank line * remove blank line * fix spaces, add function parameter
TolisChal
pushed a commit
to TolisChal/volume_approximation
that referenced
this pull request
Jul 8, 2024
* new function is_correlation_matrix * update example function call this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h * remove blank line * remove blank line * fix spaces, add function parameter
TolisChal
pushed a commit
that referenced
this pull request
Jul 17, 2024
* new function is_correlation_matrix * update example function call this example calls the is_correlation_matrix() function that is present in include/matrix_operations/EigenvaluesProblems.h * remove blank line * remove blank line * fix spaces, add function parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wrote the function
is_correlation_matrix()inside volesti/include, and further updates the example sampler which calls this very function.