🐛 [BUG] ApidaeTrekParser now ignores when no linestring in GPX

Previously caused a crash.
GeotrekCE · Sep 3, 2024 · 7acdf81 · 7acdf81
1 parent 54c8cfe
commit 7acdf81
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 0 deletions.
diff --git a/docs/changelog.rst b/docs/changelog.rst
@@ -13,6 +13,7 @@ CHANGELOG
 **Bug fixes**
 
 - ApidaeTrekParser now fallbacks on trace filename extension if no extension property
+- ApidaeTrekParser now ignores when no linestring in GPX
 
 
 2.109.1     (2024-08-22)

diff --git a/geotrek/trekking/parsers.py b/geotrek/trekking/parsers.py
@@ -939,6 +939,8 @@ def _get_geom_from_gpx(data):
                 geos = ApidaeTrekParser._maybe_get_linestring_from_layer(layer)
                 if geos:
                     break
+            else:
+                raise RowImportError("No LineString feature found in GPX layers tracks or routes")
             geos.transform(settings.SRID)
             return geos
 

diff --git a/geotrek/trekking/tests/data/apidae_trek_parser/trace_with_no_feature.gpx b/geotrek/trekking/tests/data/apidae_trek_parser/trace_with_no_feature.gpx
@@ -0,0 +1,5 @@
+<?xml version="1.0"?>
+<gpx version="1.1" creator="GDAL 3.3.1" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+     xmlns="http://www.topografix.com/GPX/1/1"
+     xsi:schemaLocation="http://www.topografix.com/GPX/1/1 http://www.topografix.com/GPX/1/1/gpx.xsd">
+</gpx>
diff --git a/geotrek/trekking/tests/test_parsers.py b/geotrek/trekking/tests/test_parsers.py
@@ -1491,6 +1491,12 @@ def test_it_handles_segment_with_single_point(self):
         self.assertEqual(geom.geom_type, 'LineString')
         self.assertEqual(len(geom.coords), 13)
 
+    def test_it_raises_an_error_when_no_linestring(self):
+        gpx = self._get_gpx_from('geotrek/trekking/tests/data/apidae_trek_parser/trace_with_no_feature.gpx')
+
+        with self.assertRaises(RowImportError):
+            ApidaeTrekParser._get_geom_from_gpx(gpx)
+
 
 class KmlToGeomTests(SimpleTestCase):