Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow displaying assigned_user field in Report Form via conf if needed (#4085) #4266

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Aug 14, 2024

Add HIDDEN_FORM_FIELDS=[] in custom.py, to enable use of assigned_user on Report outside of workflow

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@Chatewgne Chatewgne force-pushed the impr_enable_use_of_report_manager branch from de716b4 to c8dda79 Compare August 14, 2024 08:40
@Chatewgne Chatewgne changed the title Allow displaying assigned_user field in Report Form via conf if neede… Allow displaying assigned_user field in Report Form via conf if needed (#4085) Aug 14, 2024
Copy link

cypress bot commented Aug 14, 2024



Test summary

22 0 0 0


Run details

Project Geotrek-admin
Status Passed
Commit aafa863 ℹ️
Started Aug 21, 2024 8:38 AM
Ended Aug 21, 2024 8:40 AM
Duration 01:59 💡
OS Linux Ubuntu - 20.04
Browser Electron 94

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@Chatewgne Chatewgne force-pushed the impr_enable_use_of_report_manager branch from c8dda79 to 3bad9ca Compare August 14, 2024 09:31
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.38%. Comparing base (a524e91) to head (1d468e5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4266      +/-   ##
==========================================
- Coverage   98.38%   98.38%   -0.01%     
==========================================
  Files         267      267              
  Lines       20887    20886       -1     
==========================================
- Hits        20550    20549       -1     
  Misses        337      337              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Chatewgne Chatewgne marked this pull request as ready for review August 14, 2024 10:53
@bruhnild
Copy link
Contributor

Peux tu ajouter l'information dans la documention pour le paramétrage du champ ?

@Chatewgne Chatewgne force-pushed the impr_enable_use_of_report_manager branch 3 times, most recently from 0ee2855 to 4130753 Compare August 20, 2024 08:21
@Chatewgne Chatewgne changed the title Allow displaying assigned_user field in Report Form via conf if needed (#4085) 💫 [IMPR] Allow displaying assigned_user field in Report Form via conf if needed (#4085) Aug 20, 2024
@Chatewgne Chatewgne force-pushed the impr_enable_use_of_report_manager branch 3 times, most recently from 5edb647 to e0dce8d Compare August 21, 2024 08:08
@Chatewgne Chatewgne force-pushed the impr_enable_use_of_report_manager branch from e0dce8d to 1d468e5 Compare August 21, 2024 08:27
@Chatewgne Chatewgne merged commit ca7821b into master Aug 21, 2024
20 checks passed
@Chatewgne Chatewgne deleted the impr_enable_use_of_report_manager branch August 21, 2024 12:14
@babastienne babastienne changed the title 💫 [IMPR] Allow displaying assigned_user field in Report Form via conf if needed (#4085) Allow displaying assigned_user field in Report Form via conf if needed (#4085) Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants