Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 [BUG] Fix missing Annotation Categories in APIv2 for annotations other than Points (refs #4032) #4309

Merged
merged 1 commit into from
Sep 18, 2024
Merged

🐛 [BUG] Fix missing Annotation Categories in APIv2 for annotations other than Points (refs #4032) #4309

merged 1 commit into from
Sep 18, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Sep 18, 2024 •
edited
Loading

Description

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

@cypress Cypress
Copy link

cypress bot commented Sep 18, 2024 •
edited
Loading

Geotrek-admin    Run #9932

Run Properties:  status check passed Passed #9932  •  git commit 5205d1ace6 ℹ️: Merge 2b4968c6aef1a71604c1089e79ba2e5bb5eb4fd1 into 5cc1cfc75a14b6c9d4220a249d49...
Project Geotrek-admin
Branch Review refs/pull/4309/merge
Run status status check passed Passed #9932
Run duration 02m 05s
Commit git commit 5205d1ace6 ℹ️: Merge 2b4968c6aef1a71604c1089e79ba2e5bb5eb4fd1 into 5cc1cfc75a14b6c9d4220a249d49...
Committer Célia
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22
View all changes introduced in this branch ↗︎

@Chatewgne Chatewgne force-pushed the fix_missing_annotation_categories_in_api_v2 branch from 40c2b22 to 2b4968c Compare September 18, 2024 09:54
@Chatewgne Chatewgne merged commit 3192f6e into master Sep 18, 2024
16 checks passed
@Chatewgne Chatewgne deleted the fix_missing_annotation_categories_in_api_v2 branch September 18, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camillemonchicourt camillemonchicourt camillemonchicourt approved these changes

Assignees
No one assigned
Labels
🐛 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Chatewgne @camillemonchicourt