Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 [BUG] Fix errors in Aggregator when retrieving unpublished Route Steps (refs #3569) #4338

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

Chatewgne
Copy link
Contributor

@Chatewgne Chatewgne commented Oct 15, 2024

Description

  • Filter Steps by portal
  • Fix key error on UUID
  • Fetch missing categories (not published in regular list)
  • Publish some categories in API through detail view

Related Issue

Checklist

  • I have followed the guidelines in our Contributing document
  • My code respects the Definition of done available in the Development section of the documentation
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes
  • I added an entry in the changelog file
  • My commits are all using prefix convention (emoji + tag name) and references associated issues
  • I added a label to the PR corresponding to the perimeter of my contribution
  • The title of my PR mentionned the issue associated

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.40%. Comparing base (3c1f019) to head (8b7e550).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4338      +/-   ##
==========================================
- Coverage   98.41%   98.40%   -0.01%     
==========================================
  Files         267      267              
  Lines       20926    20976      +50     
==========================================
+ Hits        20594    20642      +48     
- Misses        332      334       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Oct 15, 2024

Geotrek-admin    Run #10132

Run Properties:  status check passed Passed #10132  •  git commit c7c6623801 ℹ️: Merge 8b7e55090b225cb6aea7cc0a681ad2da7decd04c into 7d721f0aca32692d436f8d3bacd6...
Project Geotrek-admin
Run status status check passed Passed #10132
Run duration 02m 07s
Commit git commit c7c6623801 ℹ️: Merge 8b7e55090b225cb6aea7cc0a681ad2da7decd04c into 7d721f0aca32692d436f8d3bacd6...
Committer Célia
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 22

@Chatewgne Chatewgne force-pushed the fix_agreg_route_unpublished_steps branch 7 times, most recently from c52b080 to ebcfa92 Compare October 16, 2024 11:09
@Chatewgne Chatewgne force-pushed the fix_agreg_route_unpublished_steps branch 3 times, most recently from ba960b4 to d51568b Compare October 16, 2024 11:33
@Chatewgne Chatewgne requested a review from a team October 16, 2024 12:24
@Chatewgne Chatewgne force-pushed the fix_agreg_route_unpublished_steps branch 2 times, most recently from 4fbbdb5 to 18e3c1b Compare October 18, 2024 15:38
@Chatewgne Chatewgne force-pushed the fix_agreg_route_unpublished_steps branch from 18e3c1b to 8b7e550 Compare October 21, 2024 07:55
@Chatewgne Chatewgne merged commit c6d255b into master Oct 21, 2024
23 checks passed
@Chatewgne Chatewgne deleted the fix_agreg_route_unpublished_steps branch October 21, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants