Restructure trek detail UI #4422
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chatewgne
reviewed
Dec 17, 2024
| @@ -77,7 +77,8 @@ <h3>{% trans "Photos accessibility" %}</h3> | |||
|
|
|||
| {% if perms|add_attachment %} | |||
| {% if user.profile.structure == object.structure or perms.authent.can_bypass_structure %} | |||
| <div class="file-attachment-accessibility-form"> | |||
| <div class="file-attachment-form"> | |||
| <h4>New accessibility photo</h4> | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4422 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 268 268
Lines 21290 21290
=======================================
Hits 20964 20964
Misses 326 326 ☔ View full report in Codecov by Sentry. |
Geotrek-admin
|
||||||||||||||||||||||||||||
| Project |
Geotrek-admin
|
| Branch Review |
refs/pull/4422/merge
|
| Run status |
|
| Run duration | 02m 06s |
| Commit |
|
| Committer | Justine Fricou |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
22
|
| View all changes introduced in this branch ↗︎ | |
… module's detail template
Chatewgne
reviewed
Dec 23, 2024
| {% smart_include "detail" %} | ||
| </div> | ||
| {% endblock %} | ||
| {% endblock relatedobjectspanel %} |
There was a problem hiding this comment.
Move relatedobjectspanel block to MapEntity, to ensure we can create generic view in MapEntity to load its content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This restructuring of the detail pages aims to reorganize the data into a different set of tabs so further developments can set up a loading system in which the data is only loaded when the user clicks on the associated tab.
Remaining work after this PR is merged:
Related Issue
Checklist